Skip to content

feat(fares-v2): add support for editing feeds with fares v2 data#1025

Merged
josh-willis-arcadis merged 92 commits intodevfrom
faresv2
May 4, 2026
Merged

feat(fares-v2): add support for editing feeds with fares v2 data#1025
josh-willis-arcadis merged 92 commits intodevfrom
faresv2

Conversation

@josh-willis-arcadis
Copy link
Copy Markdown
Contributor

@josh-willis-arcadis josh-willis-arcadis commented Jan 29, 2025

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing
  • The description lists all relevant PRs included in this release (remove this if not merging to master)
  • e2e tests are all passing (remove this if not merging to master)

Description

Adds support to the editor for feeds with fares v2 data.

josh-willis-arcadis and others added 9 commits April 24, 2026 13:04
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Copy link
Copy Markdown
Contributor

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! We can always refactor more later

Copy link
Copy Markdown
Contributor

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of nits from late last week, I'll try to finish the review today.

Comment thread lib/editor/actions/editor.js Outdated
Comment thread lib/editor/components/EditorInput.js Outdated
Comment thread lib/editor/components/EditorInput.js Outdated
Comment thread lib/editor/components/EditorInput.js Outdated
Comment thread lib/editor/components/EditorInput.js Outdated
Comment thread lib/editor/components/EditorInput.js Outdated
Comment thread lib/editor/components/EntitiySelector.js Outdated
Comment thread lib/editor/components/EntitiySelector.js Outdated
Comment thread lib/editor/components/EntityListSecondaryActions.js Outdated
Copy link
Copy Markdown
Contributor

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to approve this as the basic editing, importing and exporting seem to work. The TODOs say it all.

Comment thread lib/editor/components/EntitiySelector.js
Comment thread lib/editor/components/EditorInput.js
@josh-willis-arcadis josh-willis-arcadis merged commit e072b0e into dev May 4, 2026
5 checks passed
@josh-willis-arcadis josh-willis-arcadis deleted the faresv2 branch May 4, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants