Improve Itinerary Checks#376
Merged
binh-dam-ibigroup merged 15 commits intodevfrom May 4, 2026
Merged
Conversation
… existence result.
br648
approved these changes
Apr 29, 2026
Contributor
br648
left a comment
br648
left a comment
There was a problem hiding this comment.
Just one minor suggestion. Tests all pass. Approving.
| HttpStatus.BAD_REQUEST_400, | ||
| monitoredTrip.itineraryExistence.message | ||
| ); | ||
| String checkId = monitoredTrip.itineraryExistence != null ? monitoredTrip.itineraryExistence.id : null; |
Contributor
There was a problem hiding this comment.
I think this block would be cleaner in it's own method. Is the FIXME still a thing? The PR has been merged.
Collaborator
Author
br648
approved these changes
Apr 30, 2026
Contributor
br648
left a comment
br648
left a comment
There was a problem hiding this comment.
Yep, that looks much better. Thanks for updating.
3 tasks
amy-corson-ibigroup
approved these changes
May 1, 2026
Contributor
amy-corson-ibigroup
left a comment
amy-corson-ibigroup
left a comment
There was a problem hiding this comment.
I think this makes sense! Thank you for the changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
This PR improves itinerary checks:
/checkitinerarycall is made by a client prior to persisting, the itinerary check result is placed in a cache and consumed when the trip that triggered the check is persisted, with the condition that the client provides the check id in the trip'sitineraryExistence.idfield. This avoids performing the check again upon initial POST. IfitineraryExistence.idis not provided, the check is performed on POST as before./checkitinerarycauses the returnedItineraryExistenceto be also persisted into the existing trip. The PUT operation on an existing trip does not touch existing content initineraryExistence.Tests are added for the new logic and to solidify the existing logic.