feat(transitive-overlay): enable strict mode#34
Open
daniel-heppner-ibigroup wants to merge 7 commits intostrict-mode-toolingfrom
Open
feat(transitive-overlay): enable strict mode#34daniel-heppner-ibigroup wants to merge 7 commits intostrict-mode-toolingfrom
daniel-heppner-ibigroup wants to merge 7 commits intostrict-mode-toolingfrom
Conversation
…e deps - Set TS compile target to es2020 - Remove dep hoisting, add pnpm-workspace.yaml config - Add missing type dependencies to packages without strict-mode branches - Fix husky setup
- Enable TypeScript strict mode - Add TransitiveSegment type to @opentripplanner/types - Make stop_name optional in TransitiveStop - Add missing type dependencies
| let fromAnchor; | ||
| let toAnchor; | ||
| let fromAnchor: PositionAnchor = "top-left"; | ||
| let toAnchor: PositionAnchor = "top-left"; |
There was a problem hiding this comment.
is this a reasonable default?
daniel-heppner-ibigroup
force-pushed
the
strict-mode-tooling
branch
from
3764eff to
3c97830
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables TS strict mode and then fixes the related type issues.
This PR also touches types package to create a new TransitiveSegment type which we then use in this package.