Switched to LoggingHelper.init() to clean up duplicate logging code #313
Conversation
| @@ -58,7 +58,7 @@ public void testJmsPubSub(){ | |||
| subThread.start(); | |||
| //Wait for subscription to take place before publishing | |||
| try { | |||
| Thread.sleep(2000); | |||
| Thread.sleep(5000); | |||
There was a problem hiding this comment.
This file seems not to fit into the logging update pattern.
There was a problem hiding this comment.
In this file, we are not creating a console handler to output logs. Instead, we create a TestLogHandler to capture the logs generated by both the JMSSub and JMSPub samples, and we make assertions to verify that the expected messages were logged, it is uses custom testloghandler
There was a problem hiding this comment.
but the only change in this file is extending the sleep from 2 seconds to 5 seconds.
There was a problem hiding this comment.
yes it was because after making changes in the logging method, we got rid of the unnecessary console handlers which were causing delay in some other processes. So after making the changes the JMSPub was sending messages a bit early before even the JMSSub starts even though there was sleep delay of 2s before the Pub threads starts, So Sub app wasn't getting the first message published by the JMSPub app, that was causing the test fail, So I extend the sleep time, now the Sub thread Strats before the Pub thread and gets all the messages
…clean up the system setproperty
| @@ -58,7 +58,7 @@ public void testJmsPubSub(){ | |||
| subThread.start(); | |||
| //Wait for subscription to take place before publishing | |||
| try { | |||
| Thread.sleep(2000); | |||
| Thread.sleep(5000); | |||
There was a problem hiding this comment.
but the only change in this file is extending the sleep from 2 seconds to 5 seconds.
No description provided.