oem-ibm: Clear the staging directory in inband codeupdate flow#744
Open
ArchanaKakani wants to merge 1 commit intoibm-openbmc:1120from
Open
oem-ibm: Clear the staging directory in inband codeupdate flow#744ArchanaKakani wants to merge 1 commit intoibm-openbmc:1120from
ArchanaKakani wants to merge 1 commit intoibm-openbmc:1120from
Conversation
Currently staging directory is removed only two times 1. During starting PLDM 2. After receiving the Code update abort from phyp. Without cleaning up the staging directory, the 2nd update will start trying to repackage the same lid files and eventually fail with a signature error. Multiple code updates in a row is a IBMi only usecase. To support multiple code updates in a row, removing the staging directory just before sending the sensor event for end code update to phyp. Fixes: https://jazz07.rchland.ibm.com:13443/jazz/web/projects/CSSD#action=com.ibm.team.workitem.viewWorkItem&id=757992 Signed-off-by: Archana Kakani <archana.kakani@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently staging directory is removed only two times
Without cleaning up the staging directory, the 2nd update will start trying to repackage the same lid files and eventually fail with a signature error.
Multiple code updates in a row is a IBMi only usecase.
To support multiple code updates in a row, removing the staging directory just before sending the sensor event for end code update to phyp.
Fixes: https://jazz07.rchland.ibm.com:13443/jazz/web/projects/CSSD#action=com.ibm.team.workitem.viewWorkItem&id=757992