Update dependencies #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmsurpre
approved these changes
Jul 20, 2020
Member
lmsurpre
left a comment
lmsurpre
left a comment
There was a problem hiding this comment.
It looks fine to me, but I no longer have a custom domain to test with. Any interest in taking over maintenance of this project?
lmsurpre
reviewed
Jul 21, 2020
| @@ -1,4 +1,2 @@ | |||
| cffi >= 0.8.0 | |||
| letsencrypt >= 0.7.0 | |||
| six >= 1.7 | |||
Member
There was a problem hiding this comment.
this was for python2 compatibility and our goal was for it to run on either 2 or 3. however, I'm not even sure it was used and now python2 is end-of-life, so I'm ok with this change
letsencrypt is now certbot
The [`sleep(5)`](ibmjstart#31) had been bugging me. The failure induced by [`ibmcloud --quiet`](ibmjstart#32) triggered me to look for the exit code of the `cf ssh` command. Not the code keeps trying in a loop, but without an _initial_ sleep. The sleep seems to be required in about 50% if the cases I tried.
suhlig
force-pushed
the
update-depencencies
branch
from
7ae505a to
13d57ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR may be a bit on the heavy side, but the things it fixes are somehow related to each other. Let me know if you prefer separate PRs.
letsencrypt=>certbot, removes some unused ones)fromcf ssh` - it is probably broken in ibmcloud v1.1, and is not strictly required anyway.