Conversation
would like to use it but just get 404's with it enabled and GH configured as a trusted publisher
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the npm publish workflow to disable the provenance feature, keeping the rest of the publishing process unchanged. Flow diagram for updated npm publish workflow without provenanceflowchart TD
trigger[GitHub_Actions_Trigger push_tag_release]
job[Job publish]
checkout[Step actions_checkout]
setupNode[Step setup_Node]
installDeps[Step yarn_install]
build[Step yarn_build]
publish[Step npm_publish_access_public]
npmRegistry[NPM_Registry]
trigger --> job
job --> checkout
checkout --> setupNode
setupNode --> installDeps
installDeps --> build
build --> publish
publish -->|npm publish --access public
NODE_AUTH_TOKEN from secrets.NPM_TOKEN| npmRegistry
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
=======================================
Coverage 92.43% 92.43%
=======================================
Files 4 4
Lines 251 251
Branches 61 61
=======================================
Hits 232 232
Misses 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Consider adding a brief comment in the workflow near the publish step explaining why
--provenanceis disabled, so future changes don’t accidentally reintroduce it and break publishing again. - If you expect to re-enable provenance later, you might parameterize the flag via an input or environment variable so it can be toggled per-run or per-environment without editing the workflow.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding a brief comment in the workflow near the publish step explaining why `--provenance` is disabled, so future changes don’t accidentally reintroduce it and break publishing again.
- If you expect to re-enable provenance later, you might parameterize the flag via an input or environment variable so it can be toggled per-run or per-environment without editing the workflow.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull request overview
This PR removes the --provenance flag from the npm publish command to work around 404 errors encountered during package publishing, despite having GitHub configured as a trusted publisher.
Key Changes:
- Removes
--provenanceflag from thenpm publishcommand while retaining--access public
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
would like to use it but just get 404's with it enabled and GH configured as a trusted publisher
Summary by Sourcery
CI: