Fixed to match from zone with larger string length.#63
Open
hokupod wants to merge 2 commits intoicamys:masterfrom
Open
Fixed to match from zone with larger string length.#63hokupod wants to merge 2 commits intoicamys:masterfrom
hokupod wants to merge 2 commits intoicamys:masterfrom
Conversation
Owner
|
@hokupod Thank you for this upgrade. Could you please add a test that will cover this change? |
Author
|
@icamys |
Author
|
@icamys Regards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed parserFor method to match from zone with larger character length.
This change was made to ensure that ".co.jp" is selected instead of the zone name ".jp" if the domain name is "example.co.jp".
Regards.