Skip to content

new outputs and output fixes #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anewton1998 merged 42 commits into from
Oct 12, 2025
Merged

new outputs and output fixes #158

anewton1998 merged 42 commits into from
Oct 12, 2025

Conversation

@anewton1998
Copy link
Collaborator

@anewton1998 anewton1998 commented Oct 12, 2025

This PR does the following:

  • adds the status-text and status-json output formats
  • adds the events-json and events-text output formats
  • adds the RPSL output format
  • adds the pretty-compact-json output format
  • fixes the output code so that -p works with URL output format
  • fixes the output code so that -p works with JSON output format (this also guarantees valid JSON output)
  • changes the markdown output format to be more concise
  • fixes some issues with the markdown format
  • changes some of the colors used in the markdown output format
  • code refactoring related to output formats and new tests and test methodology using golden files
  • adds a warning when using the gTLD WHOIS format on non-domain objects
  • fixes the data model for RFC 9083 errors

k-yamamoto-dev and others added 30 commits September 7, 2025 18:56
@k-yamamoto-dev
feat(cli): add status-text and status-json outputs for primary object
a669930 
Signed-off-by: Kazuki Yamamoto <kyamamoto884@gmail.com>
@anewton1998
fix: code formatting
6102ca4
@anewton1998
Merge pull request #148 from k-yamamoto-dev/add-status-output
6ed2c61 
feat(cli): add status-text and status-json outputs for primary object

As an FYI, I may restructure some of the output code.
@anewton1998
chore: change test format
0183a78
@anewton1998
chore: added justfile and update contribution docs
0cbe466
@anewton1998
fix(test): no need for allowing non_snake_case
917e44d
@anewton1998
fix: req_target to help with output targetting for registry registrar…
026a436 
…, applied to status-text status-json
@anewton1998
refactor: got rid of do_no_output
696c957
@anewton1998
refactor: status-text output to do_output
d32cda1
@anewton1998
fix: url output now works with -p
9ede272
@anewton1998
fix: json and pretty-json output types now output valid JSON reqardle…
d80561a 
…ss of -p parameter
@anewton1998
feat(cli): events-json and events-text output types
1fca1bf
@anewton1998
Merge pull request #150 from icann/andy_dev
4bc39d0 
Output Fixes
@anewton1998
feat(cli): Add RPSL output type
fb97dba 
chore: all object types and cli flow wired up

chore: initial formatting code

chore: entity key code

chore: todos

chore: recursion on entities

chore: comments and nameservers

chore: added events and remarks

feat: addresses, emails, phones

fix!: secure_dns bools are now optional

chore: changes to make RPSL more relevant to RDAP

feat: autnum in rpsl

feat: inetnum output in rpsl

feat(rpsl): add help, error, and searches

chore: added tests
@anewton1998
Merge pull request #154 from icann/andy_dev
8dc381e 
feat(cli): Add RPSL output type
@anewton1998
fix(cli): in issue #151 using gtld-whois output with other than domain
b6077c5
@anewton1998
fix: Rfc9083Error is now compliant but had to add an extension for RDAP
274e51c
@anewton1998
fix!: help builder does not build an "object" but just a response
8c21fb6
@anewton1998
feat(cli): add pretty-compact-json output
267c57c
@anewton1998
fix(md): removing unneeded output from domain and nameserver
159d2e3
@anewton1998
fix(md): only output secure_dns if there is data
0d1a1b0
@anewton1998
fix(md): events don't print out if there aren't any
37fcbd2
@anewton1998
fix(md): separators for multiple rows of a type
05a829b
@anewton1998
chore(md): entity test
96ae3f4
@anewton1998
fix(md): removing underscore from characters that need escaping
c9c2d2b
@anewton1998
chore(rpsl): add goldenfile tests
8e670a3
@anewton1998
fix(md): no reason to have empty handle eat up space
e29e6b0
@anewton1998
fix(md): redactions now don't take up so much space
a344098
@anewton1998
Merge pull request #155 from icann/andy_dev
103a4ad 
Andy dev
@anewton1998
fix(md): domain variants now part of the domain table and code is sim…
0d2ea05 
…pler
@anewton1998 anewton1998 merged commit 7a56ba2 into main Oct 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anewton1998 @k-yamamoto-dev