fix: showing chart header title based on token type #3040
+31
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ice-phobos
force-pushed
the
fix/chart-header-title
branch
from
ef4f43c to
05de731
Compare
ice-kreios
previously approved these changes
Jan 8, 2026
lib/app/features/tokenized_communities/views/pages/tokenized_community_page.dart
Outdated
Show resolved
Hide resolved
ice-morpheus
force-pushed
the
fix/chart-header-title
branch
from
05de731 to
27a8def
Compare
ice-morpheus
force-pushed
the
fix/chart-header-title
branch
8 times, most recently
from
53adf81 to
c95c406
Compare
ice-kreios
approved these changes
Jan 9, 2026
ice-morpheus
force-pushed
the
fix/chart-header-title
branch
2 times, most recently
from
1391ca3 to
c9a357e
Compare
ice-morpheus
force-pushed
the
fix/chart-header-title
branch
from
c9a357e to
2806f78
Compare
ice-endymion
reviewed
Jan 9, 2026
| final result = tickerLower; | ||
| return result; | ||
| } | ||
| return ''; |
Contributor
There was a problem hiding this comment.
Maybe it's better to use an optional as a return value?
String? _normalizeChartTitle(CommunityToken token)
Contributor
There was a problem hiding this comment.
can this be theoretically empty at all?
Contributor
Author
There was a problem hiding this comment.
@ice-neoptolemus theoretically not, but programmatically yes ))
Contributor
Author
There was a problem hiding this comment.
@ice-endymion if you mean format as needed and just return null if the nickname is null (which theoretically can't happen), yes, this sounds a better solution, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
_normalizeChartTitlelocal function which checks token type and@nickname (ticker name)formattickerpurely as arrived from backendTask ID
ION-4982
Type of Change