Skip to content

Conversation

pernicet
Copy link
Collaborator

Extend gamma range and update dependencies for mamba install:

  • energy_pdf.py, make_SoB_splines.py: extend gamma range for analysis.
  • poetry.lock, pyproject.toml: update to support dependency install via mamba.

- energy_pdf.py, make_SoB_splines.py: extend gamma range for analysis.
- poetry.lock, pyproject.toml: update to support dependency install via mamba.
@mlincett
Copy link
Collaborator

Besides the issue with numexpr I think this is fine. It would be even better to set the range in a single place and derive the other one programmatically, but it's not so crucial.

@JannisNe
Copy link
Collaborator

This will set the default for gamma scan to start at 0.5, right? Is this what we want to do?

@mlincett
Copy link
Collaborator

This will set the default for gamma scan to start at 0.5, right? Is this what we want to do?

This is a good observation. I have no feeling about whether the minimiser could be thrown off by starting at 0.5, but for the sake of consistency with past analyses, maybe decoupling the initial values from the range is a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants