Windows/MSVC compatibility #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added preliminary code for compatibility in Windows with MS Visual Code C compiler.
setup.py checks if system is windows and changes the compilation flags to those used in Visual Code (different optimization level, no need for PIC and no Werror).
It would be better if this would be handled with checking if the compiler is MSVC, but there is no shorthand for it.
In the c-code I added check if the compiler is MSVC and changed the time-library header for correct one for MSVC if the compiler is MSVC.
Code is not tested on linux, but it should work.........