Added Support for Fragment Ids #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey Florian! Sorry for the slow response... thanks for this, I'll check it out! |
Author
|
Great! Let me know, what you think of it! |
… referenced view's viewbox
…get, name of this class is configurable via options
…e.log in dist, but leave in debug version
…e svg-root element
…within the svg-symbol will be removed and a default icon class will be applied
Do not remove existing element before insert. When the element to be replaced is the first child, it will is the same as `insertBefore`.
bugfix, replace element
…not be found in the spritesheet
…ts) that only specify a viewbox
if neiter in src svg or sprite nor in the injection-target element, do not create meaningless default `desc` and `title`. Only add `aria-labelled-by` if meaningfull `desc` and/or `title` exist
…ria-hidden` implementation
fix onDoneCallback for empty array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I tried to improve the SVGInjector's versatility by adding support for fragment-ids.
This is essential, when combining multiple svgs of a page into 1 file to save HTTP requests.
Hope you like it =)
Best regards,
Florian