[Keylog] Support new keylog format #262
Conversation
| const data: number[] = await response.json(); | ||
| setKeylog(data); | ||
| const events = await fetchNDJSON(); | ||
| const startTime = new Date(contestInfo?.status.type === ContestStatus.Type.running ? contestInfo.status.startedAtUnixMs : 0); |
|
Playwright tests screens
|
|
Playwright tests screens
|
|
Playwright tests screens
|
| case ContestStatus.Type.before: | ||
| return contestInfo.status.scheduledStartAtUnixMs ?? 0; | ||
| case ContestStatus.Type.running: |
There was a problem hiding this comment.
Need to return undefined, not 0
|
Playwright tests screens
|
|
Playwright tests screens
|
Mond1c
force-pushed
the
update-keylog-parse
branch
from
fa4ec22 to
690e872
Compare
|
Playwright tests screens
|
|
Playwright tests screens
|
|
Playwright tests screens
|
|
Playwright tests screens
|
| ); | ||
| } | ||
|
|
||
| interface KeyboardEvent { |
There was a problem hiding this comment.
Name clash with the https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent
| .trim() | ||
| .split("\n") | ||
| .filter((line) => line.trim()) | ||
| .map((line) => JSON.parse(line) as KeyboardEvent); |
There was a problem hiding this comment.
If a single last line is not fully read/written we won't be showing all the keyboard events. Maybe it's a good idea to add the try/catch somewhere else or extract this whole procedure to a function that would try to read all the events
| .trim() | ||
| .split("\n") | ||
| .filter((line) => line.trim()) | ||
| .map((line) => JSON.parse(line) as KeyboardEvent); |
There was a problem hiding this comment.
This sounds computationally heavy considering that a keylog file might be more than a megabyte. Moving it to a seperate worker that would fetch and cache the keylog data is probably a good idea
support new format