Feat: Async courses added dialogue on Calendar #1336
+160
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@alexespejo I resolved all your comments, lmk if theres anything else ! |
alexespejo
requested changes
Nov 30, 2025
KevinWu098
requested changes
Dec 3, 2025
| AppStore.off('clearSchedule', handleUpdate); | ||
| AppStore.off('currentScheduleIndexChange', handleUpdate); | ||
| }; | ||
| }, []); |
Member
There was a problem hiding this comment.
issue: Why do we have a flag that forces a rerender when courses change? My interpretation here is that we want tbaSections to be reactive to the value of AppStore.schedule.getCurrentCourses().
If so, we shouldn't "pipe" reactive events across multiple hooks.
suggestion: we can have this useEffect update the value of tbaSections stored in a useState (this means we don't have to go from "course updated" -> "update trigger" -> "update tbaSections" and instead just say "course updated" -> "update tbaSections"
Co-authored-by: Kevin Wu <kevinwu098@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a user adds Async sections to their schedule, a collapsible dialogue is now added to the bottom right of their calendar.
Alternative to #1310 that's less blaring to the user.
When screenshotted:
Test Plan
Issues
Closes #1181