-
Notifications
You must be signed in to change notification settings - Fork 1
Fixing mobile calendar selection #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
KevinWu098
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please include a before and after demo of your changes? Additionally, I believe you mentioned to me how this PR fixes the scroll behavior when users select availability on mobile (i.e. the page won't scroll while dragging), but this doesn't appear to be the case on my iPhone 12 Pro, iOS 26.
KevinWu098
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Really great improvement, very nice!
Calendar selection on mobile wasn't working - originally, the first date was being selected as the end date on all conditions
Fix:
Updated to fix personal availability selection - same issue of unwanted scrolling when trying to fill out availability.
Before (Calendar):
https://github.com/user-attachments/assets/baa4e253-ccc1-4d67-93ce-e90a81424582
After:
https://github.com/user-attachments/assets/02f06a28-ae63-4511-8b8a-9f1e78cd7c63
Before (Availability):
https://github.com/user-attachments/assets/aaf9a236-46d0-47da-9f41-6c7bfa8090a5
After:
https://github.com/user-attachments/assets/3c15336b-ebbf-46ba-a83c-4d2fcb55b518