feat: days of week meetings now pull and display current dates #232
Conversation
KevinWu098
left a comment
KevinWu098
left a comment
There was a problem hiding this comment.
Just a couple of comments. Other than that, fix the merge conflict and we should be good to go
| const dateToDisplay = availabilityDates[selectedZotDateIndex].day; | ||
|
|
||
| const displayDate = isAnchorDateMeeting(meetingDates) | ||
| ? getCurrentWeekDateForAnchor(dateToDisplay) | ||
| : dateToDisplay; | ||
|
|
||
| const formattedDate = displayDate.toLocaleDateString("en-US", { |
There was a problem hiding this comment.
issue: I don't love that we pass in meetingData and duplicate a good deal of code in order to calculate just one date for display.
suggestion: Can we refactor this so that rather than duplicate code and pass around meetingData, we could calculate this in availability and pass that value down?
There was a problem hiding this comment.
Yup, I have just removed the duplicate code and put it under convertedDates in avaliability.tsx to replace meetingDates/Data as necessary
src/lib/types/chrono.ts
Outdated
| export function getDayOfWeekFromDateString(dateString: string): number { | ||
| return new Date(dateString).getDay(); | ||
| } |
|
Is this ready to re-review? How's fixing the merge conflict coming along? |
Yes, I have hopefully fixed the merge conflict as well as the issues presented in your comments. Please let me know if there is anything else I could improve/fix, thank you! |
KevinWu098
left a comment
KevinWu098
left a comment
There was a problem hiding this comment.
LGTM! One minor nit and then we can merge
| [fromTimeMinutes, toTimeMinutes] | ||
| ); | ||
|
|
||
| const convertedDates = useMemo(() => { |
There was a problem hiding this comment.
nit: will be somewhat verbose, but how about anchorNormalizedDate? "converted" is ambiguous — converted from what? what was converted? etc
There was a problem hiding this comment.
Yup, I agree, I have changed all instances of convertedDates
| const { currentPage, itemsPerPage } = useAvailabilityPaginationStore(); | ||
|
|
||
| const { currentPage, itemsPerPage } = useAvailabilityPaginationStore( | ||
| useShallow((state) => ({ |
Summary
Video Demo
Screen.Recording.2026-01-05.at.9.05.53.PM.mov
Completes #221