Add a flag to InterfaceSoption interface kernel for solid-liquid interface#283
Open
helen-brooks wants to merge 1 commit intoidaholab:develfrom
Open
Add a flag to InterfaceSoption interface kernel for solid-liquid interface#283helen-brooks wants to merge 1 commit intoidaholab:develfrom
helen-brooks wants to merge 1 commit intoidaholab:develfrom
Conversation
helen-brooks
changed the title
Author
|
Hello @simopier this PR has gone stale, though I think we'd still be interested in adding this feature. Beyond bringing it back up to date and getting tests to pass, what criteria do we need to pass? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason
To enable
c_solid = K c_liquidinstead of
c_solid = K R T c_gasDesign
Boolean flag added to parameters which disables multiplication by RT factor.
Happy to do this differently, engaging early to discuss changes before I write a unit test for this.
Impact
Necessary for e.g. PbLi - steel interface in a gas-liquid contactor.