Fix some clippy lints and other minor adjustments#50
Open
0xdea wants to merge 13 commits intoidalib-rs:masterfrom
Open
Fix some clippy lints and other minor adjustments#500xdea wants to merge 13 commits intoidalib-rs:masterfrom
0xdea wants to merge 13 commits intoidalib-rs:masterfrom
Conversation
…n`, `use_self`, and other minor adjustments
…ute_ptr_to_ptr`, `borrow_as_ptr`, `manual_assert`, and other minor stuff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have fixed some clippy lints and applied some minor adjustments to the code. I've run tests and checked that no semver update is required, and I'm reasonably certain that my changes didn't break anything, but please see if they make sense.
You could catch some other clippy recommendations by adding something like this in
Cargo.toml:PS. My IDE (RustRover) has decided to introduce some formatting changes as well... If you don't like them, let me know and I'll undo them.