Add set_name() as IDB::set_name()#52
Open
Irate-Walrus wants to merge 2 commits intoidalib-rs:masterfrom
Open
Conversation
Irate-Walrus
changed the title
set_name() as IDB::get_name()set_name() as IDB::set_name()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
set_name()andIDB::set_name().Went by the C++ API rather that use
idb.names().set(...)or some equivalent.I don't want to hijack the PR but I have an interest in seeing
create_data()making it into the bindings. This is not necessarily easy due to the introduction oftid_tand therefore types whichidalibdoesn't handle yet. Is this something we are interested in pursuing at some point? In the meantime I"ll probably roll with my own fork that neuters that parameter.Thanks as always! 🦭