define _CRT_USE_BUILTIN_OFFSETOF to avoid usage of reinterpret_cast in offsetof macro on Windows#63
Draft
define _CRT_USE_BUILTIN_OFFSETOF to avoid usage of reinterpret_cast in offsetof macro on Windows#63
Conversation
…n offsetof macro on Windows
Member
|
@yeggor shall we take this patch vs the current one? The current one seems to be fine for now, so we can bundle this in v0.8.2, save doing another release just for this problem? |
Contributor
Author
Yeah, I was thinking the same thing. Let's use this patch for the next release. This patch is cleaner, but functionally it's not very different to what we have now. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #60. I tested it on the environment in which I had previously reproduced the issue. Build is successful from both
x64_x86 Cross Tools Command Promptandx64 Native Tools Command Prompt.