Skip to content

Dev pw#32

Merged
idblr merged 2 commits intoidblr:dev_pwfrom
huntermills707:dev_pw
May 30, 2025
Merged

Dev pw#32
idblr merged 2 commits intoidblr:dev_pwfrom
huntermills707:dev_pw

Conversation

@huntermills707
Copy link
Copy Markdown
Contributor

Andrews et al. (2020) and Slotman et al. (2022) were not very descriptive about the method used to "Population weighted NDI quintiles."

As currently implemented, Quintile cutoffs are determined by the product of the calculated NDI, and the logarithmic transform of the Total Population.

This does yield similar quintile results as the NDIQuint provided by Slotman et al. (2022) when rederiving NDIQuint using the provided NDI values joined with ACS5 Total_Population (B01001_001), but there are some discrepancies. See below:

current

Another definition would be to use a weighted quantile function, were the values are NDI, and weights are ACS5 Total_Population. I.E. distribute the NDI to each person in the tract and determine cutoffs for the entire population. Below is the comparison of this method and NDIQuint provided by Slotman et al. (2022):

proposed

This is a relatively minor change, feel free to disagree/reject. I am a python developer, and am unable to fully test the build (Ex roxygen2). I also did not see a appropriate dev branch to fork from.

@idblr idblr added enhancement New feature or request good first issue Good for newcomers labels May 28, 2025
@idblr idblr changed the base branch from main to dev_pw May 28, 2025 01:39
@idblr
Copy link
Copy Markdown
Owner

idblr commented May 28, 2025

Thanks, @huntermills707.

To confirm, you compared population-weighted NDIQuint variables derived from ndi:powell_wiley() (current & proposed versions) to NDIQuint values from Slotman et al. (2022), correct? If so, from what location did you retrieve the NDIQuint values from Slotman et al. (2022)? Did you use the August 2022 updated values) from NHLBI ADOPT?

In the meantime, I've changed the base branch to a new dev branch branch:dev_pw and will run some tests on the build. If accepted, I will release the update with the next CRAN submission.

@idblr idblr added question Further information is requested and removed good first issue Good for newcomers labels May 28, 2025
@huntermills707
Copy link
Copy Markdown
Contributor Author

huntermills707 commented May 29, 2025

Thanks, @huntermills707.

To confirm, you compared population-weighted NDIQuint variables derived from ndi:powell_wiley() (current & proposed versions) to NDIQuint values from Slotman et al. (2022), correct? If so, from what location did you retrieve the NDIQuint values from Slotman et al. (2022)? Did you use the August 2022 updated values) from NHLBI ADOPT?

In the meantime, I've changed the base branch to a new dev branch branch:dev_pw and will run some tests on the build. If accepted, I will release the update with the next CRAN submission.

Yes! I used the August 2022 updated values from NHLBI ADOPT.

@idblr idblr deleted the branch idblr:dev_pw May 30, 2025 16:22
@idblr idblr closed this May 30, 2025
@idblr idblr reopened this May 30, 2025
idblr added a commit that referenced this pull request May 30, 2025
* `Hmisc` now Imports
@idblr idblr removed the question Further information is requested label May 30, 2025
@idblr idblr merged commit b7bedd7 into idblr:dev_pw May 30, 2025
0 of 8 checks passed
idblr added a commit that referenced this pull request May 30, 2025
@idblr
Copy link
Copy Markdown
Owner

idblr commented May 30, 2025

@huntermills707 PR accepted and merged into branch:dev_pw. If you're willing and able, you're welcome to test the build with this branch while I test concurrently before merging into branch:main

idblr added a commit that referenced this pull request Aug 29, 2025
* 🔨 Prepare for PR (#32)

* `Hmisc` now Imports

* 🐛 Fix to `powell_wiley()` categorical outcome (PR #32)

* Updated population-weighted quantile method from `stats::quantile` to `Hmisc::wtd.quantile`
* Updated import statement in `powell_wiley()`

* 📝 Additional documentation for PR #32

* Prepare for CRAN v0.2.0 release

* 🐛 Fixed NOTE in CRAN checks to provide package anchors for Rd `\link{}` targets not in the package itself and the base packages  within 'ndi-package.Rd'
* 📝 In 'cran-comments.md': added valid URLs, updated test environments, and OK'd author formatting
* 📛 Updated DOI badge
* 📝 Updated vignettes with latest package version

---------

Co-authored-by: Hunter Mills <huntermills707@gmail.com>
idblr added a commit that referenced this pull request Sep 4, 2025
* 🔨 Prepare for PR (#32)

* `Hmisc` now Imports

* 🐛 Fix to `powell_wiley()` categorical outcome (PR #32)

* Updated population-weighted quantile method from `stats::quantile` to `Hmisc::wtd.quantile`
* Updated import statement in `powell_wiley()`

* 📝 Additional documentation for PR #32

* Prepare for CRAN v0.2.0 release

* 🐛 Fixed NOTE in CRAN checks to provide package anchors for Rd `\link{}` targets not in the package itself and the base packages  within 'ndi-package.Rd'
* 📝 In 'cran-comments.md': added valid URLs, updated test environments, and OK'd author formatting
* 📛 Updated DOI badge
* 📝 Updated vignettes with latest package version

* Prepare for CRAN v0.2.1 release

* 🔗 Fixed broken URLs in 'theil.Rd', 'ndi-package.Rd', 'ndi2.html', README, and NEWS

---------

Co-authored-by: Hunter Mills <huntermills707@gmail.com>
idblr added a commit that referenced this pull request Sep 4, 2025
* 🔨 Prepare for PR (#32)

* `Hmisc` now Imports

* 🐛 Fix to `powell_wiley()` categorical outcome (PR #32)

* Updated population-weighted quantile method from `stats::quantile` to `Hmisc::wtd.quantile`
* Updated import statement in `powell_wiley()`

* 📝 Additional documentation for PR #32

* Prepare for CRAN v0.2.0 release

* 🐛 Fixed NOTE in CRAN checks to provide package anchors for Rd `\link{}` targets not in the package itself and the base packages  within 'ndi-package.Rd'
* 📝 In 'cran-comments.md': added valid URLs, updated test environments, and OK'd author formatting
* 📛 Updated DOI badge
* 📝 Updated vignettes with latest package version

* Prepare for CRAN v0.2.1 release

* 🔗 Fixed broken URLs in 'theil.Rd', 'ndi-package.Rd', 'ndi2.html', README, and NEWS

* Additional preparation for CRAN v0.2.1 release

* 🔗 Fixed addition broken URLs in 'ndi2.html'

---------

Co-authored-by: Hunter Mills <huntermills707@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants