Skip to content

Conversation

@vmidyllic
Copy link
Contributor

fix Universal Circuit
This pull request primarily removes several fields from the public inputs of the credential circuits and their related test data, simplifying the circuit interface and associated test vector generation. It also updates the linked circuit test to use a more generic file and test structure.

Circuit interface simplification:

  • Removed multiple fields from the public inputs of credentialAtomicQueryV3Universal and credentialAtomicQueryV3Universal-16-16-64 circuits, including claimSchema, slotIndex, claimPathKey, operator, value, valueArraySize, isRevocationChecked, verifierID, and nullifierSessionID, leaving only the essential fields. [1] [2]

Test vector and struct updates:

  • Updated the Outputs struct in v3_universal_test.go to remove the same fields as above, ensuring consistency with the new circuit interface.
  • Modified test data generation functions (generateTestDataWithOperatorAndRevCheck and generateJSONLD_NON_INCLUSION_TestData) to stop populating the removed fields. [1] [2]
  • Removed the unused strconv import since it is no longer needed after field removals.

Test improvements:

  • Changed the linked circuit test in linked.test.ts to use linkedMultiQuery.circom instead of the version-specific linkedMultiQuery10.circom, and updated the test structure to directly provide input objects rather than loading from JSON files. [1] [2]

Kolezhniuk
Kolezhniuk previously approved these changes Jan 15, 2026
@vmidyllic vmidyllic dismissed stale reviews from Kolezhniuk and volodymyr-basiuk via 50e4775 January 15, 2026 15:47
@vmidyllic vmidyllic merged commit 3607156 into master Jan 16, 2026
2 checks passed
@vmidyllic vmidyllic deleted the fix/universal-linked branch January 16, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants