Skip to content

Conversation

@daveroga
Copy link
Contributor

@daveroga daveroga commented Jan 9, 2026

  • New hardhat.config.ts with new format
  • Scripts and tests are migrated to use ethers and ignition from hardhat network.connect().
  • Removed DeployHelper classes with old upgrades
  • Updated some ignition modules to return some contracts that are being used in tests
  • New verifyContract functionality from hardhat-verify

@daveroga daveroga marked this pull request as draft January 9, 2026 15:03
@coveralls
Copy link

coveralls commented Jan 9, 2026

Pull Request Test Coverage Report for Build 21215897126

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 59 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+8.2%) to 93.986%

Files with Coverage Reduction New Missed Lines %
contracts/identitytreestore/IdentityTreeStore.sol 1 96.56%
contracts/lib/IdentityLib.sol 1 88.03%
contracts/lib/PrimitiveTypeUtils.sol 1 88.24%
contracts/validators/auth/AuthV2Validator.sol 1 82.61%
contracts/validators/request/CredentialAtomicQueryV3Validator.sol 1 93.84%
contracts/lib/NonMerklizedIssuerBase.sol 2 0.0%
contracts/validators/request/CredentialAtomicQueryValidatorBase.sol 2 91.4%
contracts/validators/request/LinkedMultiQueryValidator.sol 2 97.45%
contracts/verifiers/Verifier.sol 4 89.49%
contracts/cross-chain/CrossChainProofValidator.sol 8 93.33%
Totals Coverage Status
Change from base Build 20393190007: 8.2%
Covered Lines: 3895
Relevant Lines: 4037

💛 - Coveralls

@daveroga daveroga marked this pull request as ready for review January 21, 2026 07:29
@daveroga daveroga requested a review from Copilot January 21, 2026 07:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request migrates the codebase from Hardhat 2 to Hardhat 3, updating configuration files, test files, deployment scripts, and ignition modules to use the new API.

Changes:

  • Updated hardhat.config.ts to use Hardhat 3's new configuration format with defineConfig and plugins
  • Migrated all test files and scripts to use ethers, ignition, and networkHelpers from network.connect()
  • Replaced deprecated Chai matchers (.reverted.revert(ethers), .changeEtherBalance.changeEtherBalance(ethers))
  • Updated ignition modules to return additional contract references needed in tests

Reviewed changes

Copilot reviewed 110 out of 113 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
hardhat.config.ts Migrated to Hardhat 3 config format with new plugin system
tsconfig.json Updated target to es2022 and module to esnext
package.json Updated dependencies and added "type": "module"
test/**/*.test.ts Migrated to use network.connect() API and updated Chai matchers
scripts/**/*.ts Updated to use network.connect() for ethers/ignition access
ignition/modules/**/*.ts Updated module returns and added new test helper modules
helpers/*.ts Updated utility functions and removed deprecated helpers

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@daveroga daveroga force-pushed the PID-3590-migrate-to-hardhat-3 branch from 8109953 to 29f15fd Compare January 21, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants