Conversation
- Updated RegisterUser to retrieve tenant ID from the current user service, ensuring user registration is context-aware. - Modified ValidateBearerTokenTenantMiddleware to validate tenant claims against the current request's tenant identifier. - Enhanced CurrentUserService to include TenantIdentifier for better tenant context handling. - Updated IdmtUserClaimsPrincipalFactory to ensure tenant claims are correctly generated and tested. - Improved unit tests for CurrentUserService and IdmtUserClaimsPrincipalFactory to cover new tenant handling logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Multi-tenant claim/validation alignment
IdmtOptionsand validates token againstTenantInfo.Identifier(notId)IdmtUserClaimsPrincipalFactorypulls tenant from store and writes the tenant claim astenantInfo.IdentifierCurrentUserServicesourcesTenantIdfrom tenant context and addsTenantIdentifier(claim or context fallback)RegisterUserresolves tenant once from context and uses it for creation/loggingTests and utilities
IdmtUserClaimsPrincipalFactoryTestsand expandedCurrentUserServiceTestscovering tenant identifier, custom claim types, andis_activeIdmtMultiTenantStrategy.DefaultHeaderNameWritten by Cursor Bugbot for commit 3ad54e0. This will update automatically on new commits. Configure here.