Skip to content

Commit 1cb938c

Browse files
fix SystemParticipantValidationUtils and test
1 parent a140d70 commit 1cb938c

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

src/main/java/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtils.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -482,13 +482,10 @@ private static List<Try<Void, InvalidEntityException>> checkStorage(StorageInput
482482
* Validates a StorageTypeInput if:
483483
*
484484
* <ul>
485-
* <li>its permissible amount of full cycles is not negative
486485
* <li>its efficiency of the electrical converter is between 0% and 100%
487-
* <li>its maximum permissible depth of discharge is between 0% and 100%
488486
* <li>its active power gradient is not negative
489487
* <li>its battery capacity is positive
490488
* <li>its maximum permissible active power (in-feed or consumption) is not negative
491-
* <li>its permissible hours of full use is not negative
492489
* </ul>
493490
*
494491
* @param storageTypeInput StorageTypeInput to validate

src/test/groovy/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtilsTest.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,7 @@ class SystemParticipantValidationUtilsTest extends Specification {
411411
where:
412412
invalidStorageType || expectedException
413413
new StorageTypeInput(uuid, id, capex, opex, eStorage, sRated, cosPhiRated, pMax, cpRate, Quantities.getQuantity(110, EFFICIENCY)) || new InvalidEntityException("Efficiency of the electrical converter of StorageTypeInput must be between 0% and 100%", invalidStorageType)
414-
new StorageTypeInput(uuid, id, capex, opex, eStorage, sRated, cosPhiRated, Quantities.getQuantity(-15, ACTIVE_POWER_IN), Quantities.getQuantity(-100, ACTIVE_POWER_GRADIENT), eta) || new InvalidEntityException("The following quantities have to be zero or positive: -15 kW, -100 %/h, -10.5 h", invalidStorageType)
414+
new StorageTypeInput(uuid, id, capex, opex, eStorage, sRated, cosPhiRated, Quantities.getQuantity(-15, ACTIVE_POWER_IN), Quantities.getQuantity(-100, ACTIVE_POWER_GRADIENT), eta) || new InvalidEntityException("The following quantities have to be zero or positive: -15 kW, -100 %/h", invalidStorageType)
415415
new StorageTypeInput(uuid, id, capex, opex, Quantities.getQuantity(0, ENERGY_IN), sRated, cosPhiRated, pMax, cpRate, eta) || new InvalidEntityException("The following quantities have to be positive: 0 kWh", invalidStorageType)
416416
}
417417

0 commit comments

Comments
 (0)