Enhancing TimeSeriesSources with method to extract future activation ticks
#1059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-activation-call # Conflicts: # CHANGELOG.md
…-activation-call # Conflicts: # CHANGELOG.md
…-activation-call # Conflicts: # CHANGELOG.md
src/test/groovy/edu/ie3/datamodel/io/source/csv/CsvWeatherSourceIconTest.groovy
Show resolved
Hide resolved
…-activation-call # Conflicts: # CHANGELOG.md
danielfeismann
previously requested changes
Jun 11, 2024
Member
danielfeismann
left a comment
danielfeismann
left a comment
There was a problem hiding this comment.
Another question from my side, the rest looks fine for me :)
src/main/java/edu/ie3/datamodel/io/source/couchbase/CouchbaseWeatherSource.java
Show resolved
Hide resolved
sebastian-peter
requested changes
Jun 12, 2024
Member
sebastian-peter
left a comment
sebastian-peter
left a comment
There was a problem hiding this comment.
Just some remarks and questions
src/main/java/edu/ie3/datamodel/io/source/sql/SqlTimeSeriesSource.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/io/source/sql/SqlWeatherSource.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/io/source/influxdb/InfluxDbWeatherSource.java
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/io/source/couchbase/CouchbaseWeatherSource.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/models/timeseries/repetitive/LoadProfileInput.java
Show resolved
Hide resolved
...3/datamodel/io/source/csv/_weather/icon/its_weather_513606bc-539e-445b-9675-2f98be3d9231.csv
Show resolved
Hide resolved
…with-future-activation-call # Conflicts: # CHANGELOG.md
Member
|
Note to myself: Does it make sense to only retrieve the next tick after the current instead? Edit: Considering the principle of discrete-event simulations, we only need the very next tick. But since a tick as a Long only takes 8 bytes of memory, we only have ~ 70 kbytes for a whole year of hourly-spaced ticks (for one time series). This does not seem like a problem (currently). |
…with-future-activation-call # Conflicts: # src/main/java/edu/ie3/datamodel/io/source/csv/CsvWeatherSource.java
sebastian-peter
approved these changes
Aug 22, 2024
Member
sebastian-peter
left a comment
sebastian-peter
left a comment
There was a problem hiding this comment.
Looks all good, thanks @staudtMarius!
sebastian-peter
deleted the
ms/#543-enhance-timeseriesSources-with-future-activation-call
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #543
Resolves #572