Bump com.github.ie3-institute:simonaAPI from 0.11.0 to 0.12.0 #1600
+389
−259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependabot
bot
added
dependencies
dependabot
bot
requested review from
danielfeismann,
sebastian-peter and
staudtMarius
as code owners
dependabot
bot
added
dependencies
dependabot
bot
force-pushed
the
dependabot/gradle/dev/com.github.ie3-institute-simonaAPI-0.12.0
branch
2 times, most recently
from
e49b3a4 to
e24ba56
Compare
Bumps [com.github.ie3-institute:simonaAPI](https://github.com/ie3-institute/simonaAPI) from 0.11.0 to 0.12.0. - [Release notes](https://github.com/ie3-institute/simonaAPI/releases) - [Changelog](https://github.com/ie3-institute/simonaAPI/blob/dev/CHANGELOG.md) - [Commits](ie3-institute/simonaAPI@0.11.0...0.12.0) --- updated-dependencies: - dependency-name: com.github.ie3-institute:simonaAPI dependency-version: 0.12.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/gradle/dev/com.github.ie3-institute-simonaAPI-0.12.0
branch
from
e24ba56 to
20be248
Compare
danielfeismann
requested changes
Dec 9, 2025
Member
danielfeismann
left a comment
danielfeismann
left a comment
There was a problem hiding this comment.
Also @sebastian-peter should have a short look on EmServiceBaseCore imho.
Comment on lines
40
to
42
| val evPower = currentType match { | ||
| case ElectricCurrentType.AC => | ||
| ev.pRatedAc | ||
| ev.sRatedAc |
Member
There was a problem hiding this comment.
As we expect evPower in Simona to be active power, this schould be sRatedAc * cosPhi in my point of view
Member
There was a problem hiding this comment.
I think this should be implemented by another PR, since this PR focuses on updating the API.
Member
There was a problem hiding this comment.
I would rather combine both... so maybe when we are fine with everything here we merge this into the other one and not into dev.
Member
There was a problem hiding this comment.
Since the other PR will take a while, I will include some changes in this PR.
src/main/scala/edu/ie3/simona/model/participant/evcs/EvModelWrapper.scala
Outdated
Show resolved
Hide resolved
src/test/scala/edu/ie3/simona/model/participant/evcs/EvcsModelSpec.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps com.github.ie3-institute:simonaAPI from 0.11.0 to 0.12.0.
Release notes
Sourced from com.github.ie3-institute:simonaAPI's releases.
Changelog
Sourced from com.github.ie3-institute:simonaAPI's changelog.
Commits
717e124typo in changelogd9c9efdMerge pull request #396 from ie3-institute/rel/df/TMP: Introducing priority triggers to SimScheduler #380-release-0-12db48f8cinclude reviewers feedback14b4510Merge branch 'dev' into rel/df/TMP: Introducing priority triggers to SimScheduler #380-release-0-12b915b7bRelease 0.12.0054b665Bump pekkoVersion from 1.2.1 to 1.3.0 (#394)6fd54f6Bump com.diffplug.spotless from 8.0.0 to 8.1.0 (#393)0128604Merge pull request #390 from ie3-institute/df/Bump akka-stream-alpakka-csv_2.13 from 4.0.0 to 5.0.0 #389-gradle-9-2-101fe670Merge branch 'dev' into df/Bump akka-stream-alpakka-csv_2.13 from 4.0.0 to 5.0.0 #389-gradle-9-2-16efa6a2Merge pull request #385 from ie3-institute/ms/Fix breaking SIMONA due to renamed messages and changed protocol in simonaAPI #384-Fix-considered-data-in-Ext...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)