Open
Conversation
Open
Open
iejMac
reviewed
Jul 31, 2022
iejMac
reviewed
Jul 31, 2022
iejMac
reviewed
Aug 3, 2022
| queue_export - SharedQueue export used re-create SharedQueue object in worker | ||
| queue_export_video - SharedQueue export for video frames, used re-create SharedQueue object in worker | ||
| queue_export_audio - SharedQueue export for audio, used re-create SharedQueue object in worker | ||
| output_dir - directory to temporarily store audio files. All the audio files will be deleted |
|
|
||
| def get_audio(vid): | ||
| if not vid.endswith(".wav"): | ||
| load_vid, dst_name = handle_youtube(vid, "audio") |
Owner
There was a problem hiding this comment.
I don't think we need two separate handle_youtube calls. Instead of making get_frames, get_audio try to unify them into get_video that takes the modalities parameter and also pass that parameter into the handle_youtube function and return everything needed. Less code is better
Owner
|
have you tested this out yet? does it work? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A place holder pull request