Open
Conversation
Problem: Bug terjadi karena query menggunakan masukan user (paramater “role” dan “functionId”) secara langsung (tanpa disanitasi) digunakan untuk menjalankan command SQL. Perbaikan: Menggunakan prepared statement untuk sanitasi parameter “role” dan “functionId”.
Problem: Variabel httpDateFormat seharusnya diproteksi agar tidak dapat diakses sembarangan dan dimodifikasi. Perbaikan: Mengubah protected menjadi private.
Problem: Variabel MAIN_SIZE seharusnya merupakan variabel final. Perbaikan: Mengubah variabel MAIN_SIZE menjadi final.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mohon maaf, Pak.. Saya kesulitan menggunakan github, belum pernah pakai sebelumnya.
Padahal tugas perbaikan dan laporan sudah selesai sebelum 31 Desember 2015 jam 23.59.