Fix duplicate call to child FSM factory function in a config object #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original bugcase I wrote for this: https://git.cryto.net/joepie91/machina-factory-bugcase
New tests are included. It still doesn't quite behave as I'd expect - namely, it creates a new child FSM for every access attempt, including every child
handleoperation, while I'd only expect it to create one upon transitioning to the parent state that contains it - but I'm still investigating that as a separate bug.EDIT: I've also added some cleanup to the event handling tests on the
machinaobject, as the error-throwing callback was interfering with the tests I added. Presumably that issue may reoccur elsewhere as well, if attached events are not reliably removed after they've been tested.