Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions web/src/shared/hooks/skill-query-helpers.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,16 @@ describe('buildSkillSearchUrl', () => {
expect(buildSkillSearchUrl({})).toBe('/api/web/skills')
})

it('keeps an empty q parameter when the search query is an empty string', () => {
expect(buildSkillSearchUrl({ q: '' })).toBe('/api/web/skills?q=')
it('omits q when the search query is an empty string', () => {
expect(buildSkillSearchUrl({ q: '' })).toBe('/api/web/skills')
})

it('normalizes whitespace-only queries to an empty q parameter', () => {
it('omits q when the normalized query is empty after trimming', () => {
expect(buildSkillSearchUrl({
q: ' ',
sort: 'relevance',
page: 0,
})).toBe('/api/web/skills?q=&sort=relevance&page=0')
})).toBe('/api/web/skills?sort=relevance&page=0')
})
})

Expand Down
2 changes: 1 addition & 1 deletion web/src/shared/hooks/skill-query-helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export function buildSkillSearchUrl(params: SearchParams) {
const queryParams = new URLSearchParams()
const normalizedQuery = normalizeSearchQuery(params.q ?? '')

if (params.q !== undefined) {
if (normalizedQuery) {
queryParams.append('q', normalizedQuery)
}

Expand Down
Loading