Add security validation for select widgets with mismatched keys and values arrays#539
Draft
Add security validation for select widgets with mismatched keys and values arrays#539
Conversation
… widgets Co-authored-by: bengaid <39761578+bengaid@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add security for select widgets with different number of "keys" and "values"
Add security validation for select widgets with mismatched keys and values arrays
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds validation to select widgets to prevent data loss when keys and values arrays have different lengths.
Problem
Previously, select widgets would silently lose data when keys and values arrays had different lengths. The render function used
Math.min(keys.length, values.length)to determine the number of options, causing:For example:
Solution
Added custom validator functions to the
WidgetActuatorDescriptionconstructors that:Changes
WidgetActuatorValidationErrorimportvalidateKeysValuesConsistency()function_KEYS_DESCRIPTOR_VALUES_STRING_DESCRIPTOR_VALUES_NUMBER_DESCRIPTOR_VALUES_BOOLEAN_DESCRIPTORValidation Demo
The validation correctly handles all scenarios:
Users now get immediate feedback about array inconsistencies instead of silent data loss, improving the security and reliability of select widgets.
Fixes #65.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.