Fix broken Selenium test and improve test/README.md #1360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the README to reflect new changes to the compatibility of the Selenium IDE addon with Firefox and Chrome, and add new instructions.
The first Selenium test case didn't work, presumably because it relied on links in the top bar that no longer exist when the user is logged out. I fixed the test case by making it access the webpages for those links directly. It was checking that a logged-out user wouldn't be able to access any of them, and I kept that in, but the test case no longer uses the top bar to navigate. I renamed the test to "Top Bar When Logged Out" in fitting with its new purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.md says not to break the Selenium tests in the
testsdirectory, but I noticed that the first Selenium test case didn't work, presumably because it relied on links in the top bar that no longer exist when the user is logged out.I fixed the test case by making it access the webpages for those links directly. It was checking that a logged-out user wouldn't be able to access any of them, and I kept that in, but the test case no longer uses the top bar to navigate.
I renamed the test to "Top Bar When Logged Out" in fitting with its new purpose.
In addition, the documentation in
test/README.mdlacked some important information about the Selenium IDE addon, which is no longer available on Chrome, and requires an additional addon to use with Firefox for security reasons. I've added this information.I also fixed a typo in the CONTRIBUTING.md file, which referred to the
testfolder astests.I don't know if anyone actually uses the Selenium tests, since there are only three of them, after all, and they really don't cover much. I haven't really used them myself. But it would be better to have all three of those tests working.