Skip to content

fix(ci): only publish NPM package when src/icons/ files change#48

Open
MonisMS wants to merge 1 commit intoig-imanish:mainfrom
MonisMS:fix/publish-only-on-icon-changes
Open

fix(ci): only publish NPM package when src/icons/ files change#48
MonisMS wants to merge 1 commit intoig-imanish:mainfrom
MonisMS:fix/publish-only-on-icon-changes

Conversation

@MonisMS
Copy link

@MonisMS MonisMS commented Feb 8, 2026

Description:

Problem

The current publish-patch.yml workflow publishes a new NPM version on
any file change (except markdown/docs/workflows). This causes
unnecessary patch version bumps when only the preview app, configuration
files, or other non-library code is updated.

Evidence of the Issue:

  • v1.0.30: Triggered by src/App.css changes (pagination CSS fixes) -
    [commit 948d760]
  • v1.0.29: Triggered by src/App.jsx changes (UI responsiveness
    updates) - [commit 1d5492b]
  • These should NOT have triggered NPM publishes since the icon library
    itself was unchanged

Solution

Changed the workflow trigger from paths-ignore (exclusion list) to
paths (inclusion list) to only trigger when files in the
src/icons/ directory are modified.

What Changed:

# Before (triggered on everything except ignored paths)
paths-ignore:
  - '**.md'
  - 'docs/**'
  - '.github/**'

# After (only triggers on icon files)
paths:
  - 'src/icons/**'

 Testing

The logic change is straightforward and reviewable. After merge, can be
verified by:
1.  Commit to src/App.jsx or other non-icon files → workflow should NOT
run
2.  Commit to src/icons/Icon.jsx or any icon component → workflow SHOULD
 run

📋 Checklist

- Clear description of changes provided
- No visual changes (workflow modification)
- References issue: Closes #47
- No tests needed (workflow configuration change)
- No documentation updates needed (internal CI/CD change)
- Follows conventional commit format (fix(ci):)

 Related

Closes #47

---
Note: Not tested in fork environment, but the logic change is
straightforward and reviewable. Happy to test if needed before merge.

@vercel
Copy link

vercel bot commented Feb 8, 2026

@MonisMS is attempting to deploy a commit to the ig-imanish's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@review-scope review-scope bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReviewScope Analysis

AI Review skipped: Change too small for meaningful AI review


Generated by ReviewScope — Senior AI Code Reviewer

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@ig-imanish
Copy link
Owner

Hey @MonisMS Thx for this PR, I will review it by today!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants