fix(ci): only publish NPM package when src/icons/ files change#48
Open
MonisMS wants to merge 1 commit intoig-imanish:mainfrom
Open
fix(ci): only publish NPM package when src/icons/ files change#48MonisMS wants to merge 1 commit intoig-imanish:mainfrom
MonisMS wants to merge 1 commit intoig-imanish:mainfrom
Conversation
|
@MonisMS is attempting to deploy a commit to the ig-imanish's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
ReviewScope Analysis
AI Review skipped: Change too small for meaningful AI review
Generated by ReviewScope — Senior AI Code Reviewer
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Owner
|
Hey @MonisMS Thx for this PR, I will review it by today! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Problem
The current
publish-patch.ymlworkflow publishes a new NPM version onany file change (except markdown/docs/workflows). This causes
unnecessary patch version bumps when only the preview app, configuration
files, or other non-library code is updated.
Evidence of the Issue:
src/App.csschanges (pagination CSS fixes) -[commit 948d760]
src/App.jsxchanges (UI responsivenessupdates) - [commit 1d5492b]
itself was unchanged
Solution
Changed the workflow trigger from
paths-ignore(exclusion list) topaths(inclusion list) to only trigger when files in thesrc/icons/directory are modified.What Changed: