Namespace paths #151
Open
Namespace paths #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The namespaced paths should always allow search in the theme vendor directory. Currently if /views/vendor/{namespace} doesn't exists it rely on the package vendor and never lookup in the theme vendor. Even if the /views/vendor/{namespace} does exists it search in /resources/themes/{THEME}/resources/views/vendor which is completely opposite to the documentation. Adding `$themeSubPaths = ["vendor/{$namespace}"];` in the sub paths will ensure the theme vendor directory lookup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The namespace paths should always allow search in the theme vendor directory.
Currently if
/views/vendor/{namespace}doesn't exists the paths will return only package vendor and never lookup in the theme vendor.Even if the
/views/vendor/{namespace}does exists it search in/resources/themes/{THEME_NAME}/resources/views/vendorwhich is completely opposite to the documentation. Adding$themeSubPaths = ["vendor/{$namespace}"];in the sub paths will ensure that the theme vendor directory is added in the paths.