make movie prop lookups case-insensitive#64
Merged
igorlira merged 1 commit intoigorlira:mainfrom Mar 20, 2026
Merged
Conversation
Lingo is case-insensitive, so `the markerlist` and `the markerList` must both resolve. Add a match_ci! macro using eq_ignore_ascii_case and apply it to get_movie_prop, set_movie_prop, Movie::get_prop, and Movie::set_prop. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fd9d85e to
50a4079
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
matchstatementsmatch_ci!macro that useseq_ignore_ascii_caseto match property names while preserving canonical camelCase in source for readabilityget_movie_prop,set_movie_prop,Movie::get_prop,Movie::set_propTest plan
_movie.markerlistvs_movie.markerList)Needed for Huai Snowball Sling.
🤖 Generated with Claude Code