Skip to content

make movie prop lookups case-insensitive#64

Merged
igorlira merged 1 commit intoigorlira:mainfrom
matthewdean:movie-props-lookup-case-insensitive
Mar 20, 2026
Merged

make movie prop lookups case-insensitive#64
igorlira merged 1 commit intoigorlira:mainfrom
matthewdean:movie-props-lookup-case-insensitive

Conversation

@matthewdean
Copy link
Collaborator

@matthewdean matthewdean commented Feb 28, 2026

Summary

  • Lingo is a case-insensitive language, but movie property lookups were using exact-match match statements
  • Adds a match_ci! macro that uses eq_ignore_ascii_case to match property names while preserving canonical camelCase in source for readability
  • Applies case-insensitive matching to all four movie prop lookup functions: get_movie_prop, set_movie_prop, Movie::get_prop, Movie::set_prop

Test plan

  • WASM build succeeds
  • Test with .dcr files that use mixed-case property access (e.g. _movie.markerlist vs _movie.markerList)

Needed for Huai Snowball Sling.

🤖 Generated with Claude Code

@matthewdean matthewdean changed the title Make movie prop lookups case-insensitive fix: make movie prop lookups case-insensitive Feb 28, 2026
@matthewdean matthewdean marked this pull request as ready for review February 28, 2026 19:16
Lingo is case-insensitive, so `the markerlist` and `the markerList`
must both resolve. Add a match_ci! macro using eq_ignore_ascii_case
and apply it to get_movie_prop, set_movie_prop, Movie::get_prop, and
Movie::set_prop.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@matthewdean matthewdean reopened this Mar 14, 2026
@matthewdean matthewdean changed the title fix: make movie prop lookups case-insensitive make movie prop lookups case-insensitive Mar 14, 2026
@matthewdean matthewdean force-pushed the movie-props-lookup-case-insensitive branch from fd9d85e to 50a4079 Compare March 14, 2026 01:35
@matthewdean matthewdean requested a review from igorlira March 14, 2026 01:49
Copy link
Owner

@igorlira igorlira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@igorlira igorlira merged commit f889d96 into igorlira:main Mar 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants