fixes for bionicle atticmedia by matthewdean · Pull Request #73 · igorlira/dirplayer-rs

matthewdean · 2026-03-12T07:51:27Z

I've developed all of these fixes in order to make Bionicle Atticmedia playable. I am confident about most of these changes but they will almost certainly introduce regressions in other games; I've flagged the changes I'm most suspicious of under the first section below.

In the future I'll try to split out and make smaller PRs for sets of related changes - can do that for this PR if desirable.

Most deserving of scrutiny

handle bare go command as gotoLoop
implement inks 37 (Light) and 39 (Dark)
use spriteListIdx to load behaviors, fall back to using channels only when needed (multiple commits)

…ream

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…ame_intervals Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

When Lingo sets sprite properties (blend, width, height, loc, member, ink, foreColor, backColor, moveable, editable), those properties become immune to score overwriting on frame transitions. This matches Director's auto-puppet behavior where go-to-the-frame loops no longer reset Lingo-modified properties each frame. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Move the SIZE_CHANGED_BY_LINGO check before NON_PROPORTIONAL_SCALE in get_concrete_sprite_rect. Integer truncation from multiplicative growth (e.g. width *= 1.1) caused the non-proportional check to override Lingo-set dimensions with the bitmap's natural size. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…dimensions Score data often stores approximate bounding-box dimensions (e.g. 316x24) rather than the bitmap's true size (400x29). Previously has_size_changed was set both by score initialization and Lingo setters, causing score bounding-box dimensions to be incorrectly trusted. The new has_lingo_size flag is only set by Lingo property setters (width, height, right, bottom), so the render heuristic in get_concrete_sprite_rect can correctly fall through to NON_PROPORTIONAL_SCALE for score-set dimensions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Director's ink type 2 is "Background Transparent" but was falling through to Copy ink in all rendering paths. Add ink 2 to every check that already handled ink 36, across GPU shaders, software rendering, and button/text paths. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…ngs corrupting frame_count Accept any entry >= 40 bytes with u32 alignment as a SpriteInfo candidate, but validate start_frame (1-100000) and end_frame (>= start_frame, <= 100000). This prevents name strings or parameter data from being misinterpreted as SpriteInfo, which produced garbage frame numbers (e.g. 0x6F6E6674 = "onft"). Also skip 3-entry groups (SpriteInfo, behaviors, name) with i += 3 instead of lookahead scanning, and remove a duplicate logging block. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…d event dispatch Parse channel 0 into a dedicated FrameScriptData struct instead of stuffing it into ScoreFrameChannelData. Attach behaviors from sprite_details via scriptSpriteListIdx. Dispatch beginSprite/enterFrame/exitFrame to channel 0 behavior instances. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Previously only lists of length 2 were handled (as pseudo-points). Now element-wise multiplication works for lists of any size, fixing errors like [142, 166, 69] * 14. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

The word_boundary commit accidentally dropped the required WHITESPACE+ separator, causing put_into/before/after chunk expression tests to fail. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

The -zstack-size flag is only valid for wasm targets but was being emitted unconditionally, preventing native cargo test from linking. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…head word_boundary checks in non-atomic rules were broken by pest's implicit whitespace insertion — the implicit WHITESPACE* between keyword and boundary check consumed the space, causing the boundary check to see the next token and fail. This broke parsing of "castLib 1", "char 1 of x", "go "choose toa"", etc. Replace with &reserved_keyword positive lookahead which runs atomically (no implicit WS), confirms keyword boundary, then consumes nothing. Also adds "member" and "put" to reserved_keyword, simplifies handler_call and command_inline by relying on lang_ident to reject reserved keywords. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

matthewdean · 2026-03-12T17:33:38Z

Still has errors on e.g. the contact info submission screen but got to a good stopping place

matthewdean · 2026-03-25T06:14:24Z

Will open a few more reasonably-sized PRs instead

matthewdean and others added 30 commits March 12, 2026 00:44

ignore claude files

36639f0

implement PushVarRef opcode

8709645

add no-op cpuHogTicks prop

2a3c99a

render with latest stage color

829ce5d

add keyPressed, make key return only ASCII

6b536fc

fix bitmap palette resolution using clut_cast_lib

292f42a

add word boundary checking to lingo

f3d65a8

add global getPos

8399a11

skip rendering solid shapes when transparent

b85f9a2

add stage bgColor prop, implement stage title prop

8cca518

add global/property/instance variable scope resolution

487eb54

add word boundary checks to Lingo grammar keywords

0e5844d

add element-wise list division

1bac592

use lingo evaluator for do command

165da9e

add string concat and constants to static eval

bf17017

allow chunk assignment on non-string datums via implicit coercion

72bba31

parse sprite detail behaviors and initializer params from raw VWSC st…

1936b15

…ream

skip D5 frame_interval behaviors for D6+

0dcb6c0

deduplicate spriteListIdx attachment, apply initializer params

a52eeb3

handle bare go command as gotoLoop

2a718bf

implement ink 37 (Light) and ink 39 (Dark)

a977c44

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix ink 0 (Copy) matte transparency for trim_white_space bitmaps

5ed6cef

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix XMED style parser truncating packed font styles

f6b60d2

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix GPU renderer incorrectly applying matte to ink 0 (Copy) sprites

000c6ea

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix XMED style parser capping styles at declared count

cd610d9

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix D6+ behavior regression: use spriteListIdx first, fall back to fr…

5a7f898

…ame_intervals Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

implement ink 3 (Ghost) for WebGL renderer

a8ae4e5

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

implement PushVarRef opcode with symbol-based variable resolution

507b1de

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix spriteListIdx dedup to not block frame_interval fallback behaviors

855e8b3

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

gitignore .mcp.json

4ae07c8

matthewdean and others added 14 commits March 12, 2026 00:47

D6+ behavior propagation: all behaviors on a sprite receive events

f925bff

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

filter mouse events to interactable sprites only

6e5c44f

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

remove leftover merge conflict marker in score chunk parser

34b3e84

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix PaletteRef::from call sites to match 3-arg signature

fa4d832

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

add the pi

cadda5d

count and number on void return 0

95a1b8f

support list * int/float multiplication for any list length

ea9c0f1

Previously only lists of length 2 were handled (as pseudo-points). Now element-wise multiplication works for lists of any size, fixing errors like [142, 166, 69] * 14. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

support string conversion for CastMember datum type

6b771f7

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

matthewdean changed the title ~~Bionicle Atticmedia fixes~~ fixes for bionicle atticmedia Mar 12, 2026

matthewdean requested a review from igorlira March 12, 2026 07:52

fix command_inline grammar: restore WHITESPACE+ between ident and args

9273cb4

The word_boundary commit accidentally dropped the required WHITESPACE+ separator, causing put_into/before/after chunk expression tests to fail. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

matthewdean marked this pull request as ready for review March 12, 2026 08:05

matthewdean and others added 2 commits March 12, 2026 10:00

fix build.rs: only emit wasm-specific linker arg when targeting wasm32

94af0ae

The -zstack-size flag is only valid for wasm targets but was being emitted unconditionally, preventing native cargo test from linking. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

matthewdean closed this Mar 25, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixes for bionicle atticmedia#73

fixes for bionicle atticmedia#73
matthewdean wants to merge 47 commits intoigorlira:mainfrom
matthewdean:bionicle-atticmedia

matthewdean commented Mar 12, 2026

Uh oh!

matthewdean commented Mar 12, 2026

Uh oh!

matthewdean commented Mar 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

matthewdean commented Mar 12, 2026

Most deserving of scrutiny

Uh oh!

matthewdean commented Mar 12, 2026

Uh oh!

matthewdean commented Mar 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant