Skip to content

Fix bitmap palette resolution and XMED style parsing#86

Open
matthewdean wants to merge 3 commits intomainfrom
bionicle-atticmedia-bug-fixes
Open

Fix bitmap palette resolution and XMED style parsing#86
matthewdean wants to merge 3 commits intomainfrom
bionicle-atticmedia-bug-fixes

Conversation

@matthewdean
Copy link
Collaborator

@matthewdean matthewdean commented Mar 25, 2026

Summary

  • Fix bitmap palette resolution to use clut_cast_lib from BitmapInfo metadata instead of always using the bitmap's own cast library. This fixes cross-cast-lib palette references.
  • Update all PaletteRef::from call sites to match the new 3-arg signature (palette_id, clut_cast_lib, bitmap_cast_lib)
  • Fix XMED styled text parser to parse all available styles rather than capping at the declared style count, which could be inaccurate

Notes

Pure bug fixes — no new features or behavioral changes. Part 2 of a series splitting the bionicle-atticmedia branch into reviewable PRs.

Test plan

  • Builds with wasm-pack build --dev --target web
  • Verify bitmaps with cross-cast-lib palettes render correctly
  • Verify styled text fields display all styles

🤖 Generated with Claude Code

matthewdean and others added 3 commits March 24, 2026 23:29
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@matthewdean matthewdean marked this pull request as ready for review March 25, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant