Simplify IGV repaint() cycle significantly. #1811
Merged
+123
−132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the IGV repaint cycle to simplify the logic and improve thread safety. The main change replaces complex track-based pending state tracking with a simple boolean flag, reducing code complexity while maintaining correct behavior.
Changes:
- Simplified repaint synchronization by replacing
Set<Track> pendingTrackswithboolean repaintPendingflag - Improved thread safety by extending the synchronization lock to cover the entire check-and-set operation when building the futures list
- Removed redundant EDT invocation wrapper in
checkPanelLayouts()since all callers already invoke it on the EDT - Cleaned up unused fields in RulerPanel (
darkModeandshowInsertions)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/sessions/100_bigwigs.xml | Updated test session configuration with different locus, reordered resources, and adjusted panel dimensions |
| src/main/java/org/igv/ui/panel/RulerPanel.java | Removed unused darkMode and showInsertions fields and cleaned up whitespace |
| src/main/java/org/igv/ui/IGV.java | Refactored repaint cycle: replaced track-based pending state with boolean flag, improved synchronization, and streamlined logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.