Skip to content

New Features, Optimizations, and Code Style Improvements #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

New Features, Optimizations, and Code Style Improvements #14

wants to merge 5 commits into from

Conversation

ihasTaco
Copy link
Owner

@ihasTaco ihasTaco commented Aug 4, 2023

This pull request introduces numerous features and bug fixes, including optimizations to improve the bot's reliability when querying multiple servers. Additionally, we've made coding style enhancements and important updates to the Backend API.

List of Changes

  • Optimizations: Enhanced the bot to reliably query multiple servers simultaneously, using the servers' refresh_interval to keep queries on time and regularly updated.
  • Code Style: Integrated ESLint to ensure consistent coding styles across the codebase.
  • Backend API Updates: Simplified the writing of queryState by introducing a new API that only writes the messageID, eliminating redundancy.
  • Variable Naming: Shifted from snake_case to camelCase for variable names and made other variable naming improvements.
  • Guild Threshold Feature: Added a feature to check if the bot is in a set amount of guilds (default: 2500) and restart the bot, using sharding after reaching the threshold. Note: This feature is still under development and hasn't been thoroughly tested. Use with caution!

ihasTaco added 5 commits August 1, 2023 19:08
@ihasTaco
Merge pull request #10 from ihasTaco/main
7a783fa 
Added a temporary notice
@ihasTaco
Fixed some issues, and added logging
68f88f0 
I believe I have fixed a couple of issues:

* Possible Fix for [issue #9](#9)

* Possible Fix for [issue #1](#1)

Added a new feature

* Added a logging system
@ihasTaco
Graph Changes
0ded89f 
I've added a fix for the graph height issue for issue #12

Changed how Trend data is calculated, the trend data will now include the first days worth of data
@ihasTaco
Optimization Update
476cfb5 
I am working on optimizing the bot so that it will run smoother and faster

I've also changed a bunch of variable names, and set up ESLint to help with consistency and find errors quicker

Please note, this will only process the servers.json file once and will just halt, as I havent set up the loop yet!
@ihasTaco
Added Looping Functionality
eb81b2e 
Ive added looping functionality to the bot, also I've fixed an issue where the guild wasnt being initialized if the bot was added when the bot was running
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 4, 2023
View reviewed changes
backend/api/get/localRoutes.js
});
});

fs.readFile('./public/server_info.json', 'utf8', (err, data) => {
if (err) throw err;

Check failure

Code scanning / CodeQL

Server crash

The server of [this route handler](1) will terminate when an uncaught exception from this location escapes an [asynchronous callback](2).
backend/api/get/localRoutes.js
serverInfo[guild_id] = {};
}
if (!serverInfo[guild_id][server_uuid]) {
serverInfo[guild_id][server_uuid] = {

Check warning

Code scanning / CodeQL

Prototype-polluting assignment

This assignment may alter Object.prototype if a malicious '__proto__' string is injected from [user controlled input](1).
backend/api/post/postRoutes.js
if (!(server_uuid in jsonData[guild_id])) {
jsonData[guild_id][server_uuid] = {
if (!(serverUUID in jsonData[guildID])) {
jsonData[guildID][serverUUID] = {

Check warning

Code scanning / CodeQL

Prototype-polluting assignment

This assignment may alter Object.prototype if a malicious '__proto__' string is injected from [user controlled input](1).
backend/api/post/postRoutes.js
jsonData[guild_id][server_uuid].status = server_info.status;
jsonData[guild_id][server_uuid].last_restart = server_info.last_restart;
jsonData[guild_id][server_uuid].message_id = server_info.message_id;
jsonData[guildID][serverUUID].map = queryState.map;

Check warning

Code scanning / CodeQL

Prototype-polluting assignment

This assignment may alter Object.prototype if a malicious '__proto__' string is injected from [user controlled input](1).
backend/api/post/postRoutes.js
jsonData[guildID][serverUUID].map = queryState.map;
jsonData[guildID][serverUUID].players.push(queryState.active_players);
jsonData[guildID][serverUUID].ping.push(queryState.ping);
jsonData[guildID][serverUUID].status = queryState.status;

Check warning

Code scanning / CodeQL

Prototype-polluting assignment

This assignment may alter Object.prototype if a malicious '__proto__' string is injected from [user controlled input](1).
backend/api/post/postRoutes.js
jsonData[guildID][serverUUID].players.push(queryState.active_players);
jsonData[guildID][serverUUID].ping.push(queryState.ping);
jsonData[guildID][serverUUID].status = queryState.status;
jsonData[guildID][serverUUID].last_restart = queryState.last_restart;

Check warning

Code scanning / CodeQL

Prototype-polluting assignment

This assignment may alter Object.prototype if a malicious '__proto__' string is injected from [user controlled input](1).
@ihasTaco ihasTaco marked this pull request as draft August 4, 2023 19:53
This was linked to issues Aug 4, 2023
Bot Occasionally Fails to Update Embeds #2
Closed
Bot Fails to Update Guild List When a New Guild is Added #3
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bot Fails to Update Guild List When a New Guild is Added Bot Occasionally Fails to Update Embeds
1 participant
@ihasTaco