Added CSS for home page slide out menu#457
Open
floydianslips wants to merge 8 commits intoiiab:masterfrom
Open
Added CSS for home page slide out menu#457floydianslips wants to merge 8 commits intoiiab:masterfrom
floydianslips wants to merge 8 commits intoiiab:masterfrom
Conversation
Member
|
@floydianslips can you throw a screenshot onto this ticket? (To help others understand what's being proposed?) |
Contributor
|
I'm worried about the regression in cmdsrv3.py ctl_bluetooth. Also the change in formatting makes it very difficult to find the actual changes, though it is more readable. (BTW I use space, not tabs and 2 columns for html, css, js.) Any way you could: |
Contributor
|
I've been through this quite a few times. Would I be right in thinking that apart from all the format changes, the real changes are in js-menu.css: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has a lot of changes to the files. Most of them are just formatting changes by VS Code. I don't have time to adjust the rules I have setup for VS code so if you are interested in the changes without the formatting let me know.