Skip to content

feat: add telemetry env vars to quickstart Docker templates#8

Open
ytallo wants to merge 1 commit intomainfrom
feat/telemetry-docker-env-vars
Open

feat: add telemetry env vars to quickstart Docker templates#8
ytallo wants to merge 1 commit intomainfrom
feat/telemetry-docker-env-vars

Conversation

@ytallo
Copy link

@ytallo ytallo commented Mar 19, 2026

Summary

  • Add ENV III_CONTAINER=docker and ENV III_ENV=development to all 4 quickstart service Dockerfiles (client, compute-service, data-service, payment-service)
  • Add III_HOST_USER_ID=${III_HOST_USER_ID:-} passthrough to all services in docker-compose.yaml

Context

Addresses review item #6 from iii-hq/iii#1320 — quickstart templates were missing the telemetry environment variables required by the Amplitude Metrics PRD Section 5.

These env vars enable:

  • III_CONTAINER=docker: Authoritative container detection signal for telemetry
  • III_ENV=development: Environment classification for the env user property
  • III_HOST_USER_ID: Correlates container events back to the host user identity in Amplitude

Test plan

  • Build quickstart services with docker compose build and verify env vars are set inside containers
  • Run docker compose up and confirm iii engine receives III_HOST_USER_ID from connected services
  • Verify is_container=true and container_runtime=docker appear in Amplitude events from containerized services

Summary by CodeRabbit

  • Chores
    • Updated Docker Compose configuration with a new environment variable for host user identification across all services.
    • Added environment metadata variables to Docker images for container identification and environment tracking in quickstart services.

- Add ENV III_CONTAINER=docker and ENV III_ENV=development to all 4 service Dockerfiles
- Add III_HOST_USER_ID passthrough to all services in docker-compose.yaml
- Enables container detection and host user correlation for Amplitude telemetry
@coderabbitai
Copy link

coderabbitai bot commented Mar 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3e9e0df1-0a70-4462-abce-4c5755928b75

📥 Commits

Reviewing files that changed from the base of the PR and between 692cb75 and 780e29e.

📒 Files selected for processing (5)
  • templates/iii/quickstart/docker-compose.yaml
  • templates/iii/quickstart/services/client/Dockerfile
  • templates/iii/quickstart/services/compute-service/Dockerfile
  • templates/iii/quickstart/services/data-service/Dockerfile
  • templates/iii/quickstart/services/payment-service/Dockerfile

📝 Walkthrough

Walkthrough

This pull request adds environment variable configurations across Docker Compose and service Dockerfiles. The docker-compose.yaml now passes III_HOST_USER_ID from the host environment to all services (client, compute-service, data-service, payment-service). Additionally, each service's Dockerfile sets III_CONTAINER=docker and III_ENV=development environment variables.

Changes

Cohort / File(s) Summary
Docker Compose Configuration
templates/iii/quickstart/docker-compose.yaml
Added III_HOST_USER_ID environment variable to all four services, sourced from host environment with empty string fallback.
Service Dockerfiles
templates/iii/quickstart/services/client/Dockerfile, templates/iii/quickstart/services/compute-service/Dockerfile, templates/iii/quickstart/services/data-service/Dockerfile, templates/iii/quickstart/services/payment-service/Dockerfile
Added III_CONTAINER=docker and III_ENV=development environment variables to each service's Docker image.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related issues

Suggested reviewers

  • andersonleal

Poem

🐰 A rabbit hops with joy today,
Environment vars pave the way!
Docker containers now know their place,
With III_CONTAINER and ENV set with grace! 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes—adding telemetry environment variables to quickstart Docker templates—matching the actual modifications across Dockerfile and docker-compose.yaml files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/telemetry-docker-env-vars
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant