feat: add telemetry env vars to quickstart Docker templates#8
feat: add telemetry env vars to quickstart Docker templates#8
Conversation
- Add ENV III_CONTAINER=docker and ENV III_ENV=development to all 4 service Dockerfiles - Add III_HOST_USER_ID passthrough to all services in docker-compose.yaml - Enables container detection and host user correlation for Amplitude telemetry
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThis pull request adds environment variable configurations across Docker Compose and service Dockerfiles. The docker-compose.yaml now passes Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related issues
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
ENV III_CONTAINER=dockerandENV III_ENV=developmentto all 4 quickstart service Dockerfiles (client, compute-service, data-service, payment-service)III_HOST_USER_ID=${III_HOST_USER_ID:-}passthrough to all services indocker-compose.yamlContext
Addresses review item #6 from iii-hq/iii#1320 — quickstart templates were missing the telemetry environment variables required by the Amplitude Metrics PRD Section 5.
These env vars enable:
III_CONTAINER=docker: Authoritative container detection signal for telemetryIII_ENV=development: Environment classification for theenvuser propertyIII_HOST_USER_ID: Correlates container events back to the host user identity in AmplitudeTest plan
docker compose buildand verify env vars are set inside containersdocker compose upand confirm iii engine receivesIII_HOST_USER_IDfrom connected servicesis_container=trueandcontainer_runtime=dockerappear in Amplitude events from containerized servicesSummary by CodeRabbit