Remove rollup-plugin-ts #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijlee2
force-pushed
the
remove-rollup-plugin-ts
branch
from
5f86b6d to
a2641ca
Compare
This was referenced Jul 5, 2023
ijlee2
force-pushed
the
remove-rollup-plugin-ts
branch
from
3199e2b to
9a1d914
Compare
ijlee2
commented
Jul 5, 2023
Comment on lines
+10
to
+20
| interface ElementHelperSignature<T extends string> { | ||
| Args: { | ||
| Positional: [name: T]; | ||
| }; | ||
| Return: ComponentLike<{ | ||
| Blocks: { default: [] }; | ||
| Element: T extends keyof HTMLElementTagNameMap | ||
| ? HTMLElementTagNameMap[T] | ||
| : Element; | ||
| }>; | ||
| } |
Owner
Author
There was a problem hiding this comment.
ijlee2
commented
Jul 5, 2023
| @@ -1,4 +1,3 @@ | |||
| {{! @glint-ignore: ember-element-helper needs to provide Glint signature }} | |||
Owner
Author
There was a problem hiding this comment.
it looks like a bug
specifically, if I set
noEmitOnError: false, declarations are emittedI'm guessing it happens to work with
--buildbecause that will always emit declarations, regardless of errors (because--buildprioritizes having declarations available for your other project references)ah
it's because of the
@glint-ignorehere
https://github.com/ijlee2/ember-container-query/blob/4.0.4/ember-container-query/src/components/container-query.hbs#L1the bug appears to be that TS internally is counting that as an error that triggers
noEmitOnErrorbehaviorif I add an entry for
elementin the registry inunpublished-development-types, everything works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request checks the solution from embroider-build/addon-blueprint#136. It can also serve as a migration guide for v2 addons that use Glint.