Feature/finished/kec jan 19 #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement EntityKey interface for unique entity identification combining pattern and element sequences - Add NidCodec6 for encoding 6-bit pattern + 26-bit element into 32-bit NIDs - Add KeyUtil with byte array conversion utilities for entity keys - Refactor LoadEntitiesFromProtobufFile to use multi-pass import with structured concurrency - Add entity key lookup methods to PrimitiveData service - Improve import performance with buffered streams and parallel processing - Add manifest verification and watch list debugging capabilities
- Add SequentialNidEntityKey for non-pattern-encoded providers - Implement default getEntityKey methods in PrimitiveDataService - Add requiresMultiPassImport() method to determine provider import needs - Auto-detect import mode based on provider in LoadEntitiesFromProtobufFile - Add integration test for auto-detected import mode - Verify SpinedArray uses single-pass import correctly
- Add findCanonicalSemanticNid method to identify correct semantic when duplicates exist - Replace UUID-based lookup with canonical semantic resolution for inferred and navigation semantics - Log warnings when duplicates are detected from past race conditions - Handle edge case where no semantic matches canonical UUID - Remove unused imports and reorganize import statements
- Replace EntityHandle.getEntityOrThrow() with Entity.nid() in semantic transformer - Entity.nid() assigns NIDs without requiring entity existence in database - Update test expectations: single-pass import now succeeds with forward references - Add pattern validation in findCanonicalSemanticNid() to detect indexing issues - Improve error logging to distinguish wrong-pattern vs duplicate semantics - Return empty Optional when all semantics have wrong pattern instead of failing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.