Open
Conversation
Add comments Add some basic debugging logic
Author
|
Hi, I just made the updates requested! Thanks, |
ilanco
requested changes
May 5, 2017
Owner
ilanco
left a comment
ilanco
left a comment
There was a problem hiding this comment.
Hi Aaron, I am willing to commit this, but could you create a new pull request and compact all your changes into one commit. Thanks.
gravity-forms-multi-currency.php
Outdated
|
|
||
| if ($is_valid_form) { | ||
| $form = RGFormsModel::get_form_meta($form_id); | ||
| $form = GFAPI::get_form($form_id); |
Owner
There was a problem hiding this comment.
No need to get the form again if we already got in on line 66. Does this get the form meta data as well?
There was a problem hiding this comment.
It doesn't work anymore. Could you please fix it to work with latest WP & GF versions. Thanks
|
It doesn't work anymore. Could you please fix it to work with latest WP & GF versions. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I updated the plugin replacing the new deprecated RGFormsModel:: calls with GFAPI::. I tested this using the latest VVV and it works great!
Please let me know if you need anything else from me.
Have a great day!
Aaron