Conversation
m-novikov
force-pushed
the
cancel-tiles-volumina
branch
from
7fae009 to
e51cc5f
Compare
m-novikov
force-pushed
the
cancel-tiles-volumina
branch
from
e51cc5f to
c1bc989
Compare
m-novikov
force-pushed
the
cancel-tiles-volumina
branch
from
a99e024 to
386d3ea
Compare
m-novikov
force-pushed
the
cancel-tiles-volumina
branch
from
386d3ea to
4e58dfb
Compare
| stack_id = stack_id or self._current_stack_id | ||
| tile_nos = self.tiling.intersected(rectF) | ||
| to_cancel = self._current_requests | ||
| self._current_requests = {} |
There was a problem hiding this comment.
Volumina's code is kinda hard to navigate, so I'd love to see some type annotations like
self._current_requests: Mapping[Tuple[LAYER_ID, ImageSource, REQUEST_ID], ArrayRequest] = {}
| else: | ||
| ims_req.cancel() | ||
|
|
||
| self._current_requests.pop((stack_id[1], ims, tile_nr), None) |
There was a problem hiding this comment.
Are you using pop here because the request might have been already removed from self._current_requests?
This kinda makes me think if it would be possible for a request to overwrite an older one; If I, say, load an image in a layer, make a request, drop that layer, then load another image and make another request, is it possible for the second request to overwrite the previous one? Even worse, is it possible for the second one to be cancelled when we meant to cancel the first?
|
closed in favor of #339 |
3 participants
No description provided.