This repository was archived by the owner on Jun 15, 2018. It is now read-only.
bug fix: improve detection of 'cookiejar' argument #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When passing clean LWPCookieJar() object, it is retyped to False, which resulted in creating new CookieJar(). Comparison to None is necessary.
In Python2, cookielib.LoadError is a subclass of IOError, but in Python3, http.cookiejar.LoadError is a subclass of OSError. Catching LoadError should be portable enough.
Author
|
In the last commit I've also fixed exception handling for cookie loading with respect to Python2/Python3 differences. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing clean LWPCookieJar() object, it is retyped to False, which resulted in creating new CookieJar(). Comparison to None is necessary.