Skip to content

DEVO-1214 - Updating to nodejs version 24. #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsclifford merged 1 commit into from
Mar 12, 2026
Merged

DEVO-1214 - Updating to nodejs version 24. #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/reusable-build-and-review-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ on:
description: The version of node to build the action with.
required: false
type: string
default: '20.x'
default: '24.x'

jobs:
setup:
Expand All @@ -76,7 +76,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
fetch-depth: 0

Expand Down Expand Up @@ -141,16 +141,16 @@ jobs:

- name: Checkout
if: env.HAS_CODE_CHANGES == 'true'
uses: actions/checkout@v4
uses: actions/checkout@v6

# -----------------------------------
# Check if action has been recompiled
# -----------------------------------
- name: If action has build step - Setup Node ${{ inputs.node-version }}
uses: actions/setup-node@v4
uses: actions/setup-node@v6
if: env.HAS_CODE_CHANGES == 'true' && env.HAS_BUILD_STEP == 'true'
with:
node-version: ${{ inputs.node-version }} # Default is 20.x
node-version: ${{ inputs.node-version }} # Default is 24.x

- name: If action has build step - Build the action
if: env.HAS_CODE_CHANGES == 'true' && env.HAS_BUILD_STEP == 'true'
Expand Down Expand Up @@ -194,7 +194,7 @@ jobs:
- name: Fail the workflow if there are any outstanding changes
if: env.HAS_CODE_CHANGES == 'true' && (env.NEEDS_BUILD_COMMIT == 'true' || env.NEEDS_README_COMMIT == 'true')
id: summary
uses: actions/github-script@v7
uses: actions/github-script@v8
with:
script: |

Expand Down Expand Up @@ -262,7 +262,7 @@ jobs:
# ----------------------------------------------------
- name: Add comment if contributing guidelines are satisfied
if: env.HAS_CODE_CHANGES == 'true' && env.NEEDS_BUILD_COMMIT == 'false' && env.NEEDS_README_COMMIT == 'false'
uses: actions/github-script@v7
uses: actions/github-script@v8
with:
script: |

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/reusable-increment-version-on-merge.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
steps:
- name: Check if merge to default branch
id: merge
uses: actions/github-script@v7
uses: actions/github-script@v8
with:
script: |
const defaultBranch = '${{ inputs.default-branch }}';
Expand All @@ -60,7 +60,7 @@ jobs:

- name: Checkout
if: env.MERGE_TO_MAIN == 'true'
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: If PR is merged to ${{ inputs.default-branch }} - Check for code changes to the action source code
if: env.MERGE_TO_MAIN == 'true'
Expand All @@ -82,7 +82,7 @@ jobs:

- name: If PR is merged to ${{ inputs.default-branch }} & PR has source code changes - Checkout
if: env.MERGE_TO_MAIN == 'true' && steps.source-code.outputs.HAS_CHANGES == 'true'
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
fetch-depth: 0

Expand Down
Loading