-
Notifications
You must be signed in to change notification settings - Fork 0
docs: update documentation on transform function #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update documentation on transform function #124
Conversation
Deploying image-js-docs with
|
Latest commit: |
2712e93
|
Status: | ✅ Deploy successful! |
Preview URL: | https://81a0eeeb.image-js-docs.pages.dev |
Branch Preview URL: | https://123-update-documentation-on.image-js-docs.pages.dev |
0cf1e5e
to
942a235
Compare
d41ed2a
to
5f0df19
Compare
dac82a4
to
e23f98b
Compare
ca032fd
to
86dc5b4
Compare
I have some doubts about some parts of the tutorial that i want to mention @stropitek :
|
Good work on the tutorial!
You can add a reference if you have a good one, but let's not go into too many mathematical details in those tutorials. They should remain simple. In the example which multiplies matrices, you can also show how to do the calculation with
Yes you can add a new page to "features/geometry". I think an explanation / API description should be enough, it's not easy to do a useful demo for
Do you mean the gif at the beginning? If you have done it yourself you can correct it if it's not too much work. If you found it, it is fine you can leave it like that without further explanations.
Yes why not, you can create an issue about this. Would be nice to have a (not necessarily exhaustive) list of methods which have those options. Would be an opportunity to check that they all share the same API as well.
This is not a published library so you can revert that change and disable the |
322451d
to
8da604b
Compare
248e989
to
4cadbab
Compare
|
@EscapedGibbon as it is really difficult to have a working state for the build when updating any dependency, I reverted to the package-lock of the We don't need to update Let's handle deps update in a future PR. |
Then I only modify the part about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought from our discussions that you would update this example to show how the matrix could also be computed using mljs by multipling a translation and a rotation together.
Otherwise LGTM.
Yeah, you're right, I think it can be combined into one section. |
No description provided.